Remove class nesting #585
Merged
Remove class nesting #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nesting the class inside a function generates bad code in Debug (microsoft#584). Unnesting seems to fix this.
|
So this almost halves the time taken in Before PR: After this PR: There also seems to be an improvement on time for Release. I am going to investigate this more deeply. |
|
The issues seems to be dependent on the version of Clang. On Clang-10, I had slow downs, but not on Clang-12. |
|
I propose taking this refactoring. |
|
Hrm. It LGTM but the cluster CI seems to be acting up. I'll look when I get a minute or when I get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nesting the class inside a function generates bad code in Debug (#584). Unnesting seems to fix this.